Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API docs: macros. Standard Documentation Checklist #44160

Merged
merged 3 commits into from
Aug 31, 2017
Merged

API docs: macros. Standard Documentation Checklist #44160

merged 3 commits into from
Aug 31, 2017

Conversation

AndyGauge
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2017 

[00:58:58] failures:
[00:58:58] 
[00:58:58] ---- macros.rs - eprint (line 196) stdout ----
[00:58:58] 	error[E0423]: expected function, found macro `eprint`
[00:58:58]  --> macros.rs:4:1
[00:58:58]   |
[00:58:58] 4 | eprint("Error: Could not complete task");
[00:58:58]   | ^^^^^^ did you mean `eprint!(...)`?
[00:58:58] 
[00:58:58] thread 'rustc' panicked at 'couldn't compile the test', /checkout/src/librustdoc/test.rs:280:12
[00:58:58] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:58:58] 
[00:58:58] ---- macros.rs - eprintln (line 224) stdout ----
[00:58:58] 	error[E0423]: expected function, found macro `eprint`
[00:58:58]  --> macros.rs:4:1
[00:58:58]   |
[00:58:58] 4 | eprint("Error: Could not complete task");
[00:58:58]   | ^^^^^^ did you mean `eprint!(...)`?
[00:58:58] 
[00:58:58] thread 'rustc' panicked at 'couldn't compile the test', /checkout/src/librustdoc/test.rs:280:12
[00:58:58] 
[00:58:58] 
[00:58:58] failures:
[00:58:58]     macros.rs - eprint (line 196)
[00:58:58]     macros.rs - eprintln (line 224)
[00:58:58] 
[00:58:58] test result: FAILED. 842 passed; 2 failed; 10 ignored; 0 measured; 0 filtered out

@arielb1 arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2017
@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you, this looks great!

@bors
Copy link
Contributor

bors commented Aug 30, 2017

📌 Commit 80d513a has been approved by steveklabnik

@alexcrichton alexcrichton mentioned this pull request Aug 30, 2017
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 30, 2017
@alexcrichton
Rollup merge of rust-lang#44160 - AndyGauge:api-docs-macros, r=stevek…
c0812c8 
…labnik

API docs: macros.  Standard Documentation Checklist

Fixes rust-lang#29381
r? @steveklabnik
bors added a commit that referenced this pull request Aug 31, 2017
@bors
Auto merge of #44186 - alexcrichton:rollup, r=alexcrichton
890c87b 
Rollup of 8 pull requests

- Successful merges: #44044, #44089, #44116, #44125, #44154, #44157, #44160, #44172
- Failed merges: #44162
@bors bors merged commit 80d513a into rust-lang:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndyGauge @rust-highfive @arielb1 @steveklabnik @bors